DevTools: include traces when exporting console log via 'Save as'

third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 639 matching lines @@
         function writeNextChunk(stream, error)
         {
             if (messageIndex >= this.itemCount() || error) {
                 stream.close();
                 progressIndicator.done();
                 return;
             }
             var lines = [];
             for (var i = 0; i < chunkSize && i + messageIndex < this.itemCount(); ++i) {
                 var message = this.itemElement(messageIndex + i);
-                lines.push(message.searchableElement().deepTextContent());
+                lines.push(message.formattedMessage().deepTextContent());
             }
             messageIndex += i;
             stream.write(lines.join("\n") + "\n", writeNextChunk.bind(this));
             progressIndicator.setWorked(messageIndex);
         }
 
     },
 
     /**
      * @param {!WebInspector.ConsoleViewMessage} lastMessage
@@ skipping 557 matching lines @@
  * @param {number} nestingLevel
  */
 WebInspector.ConsoleCommand = function(message, linkifier, nestingLevel)
 {
     WebInspector.ConsoleViewMessage.call(this, message, linkifier, nestingLevel);
 }
 
 WebInspector.ConsoleCommand.prototype = {
     /**
      * @override
-     * @return {!Element})
+     * @return {!Element}
      */
-    searchableElement: function()
+    formattedMessage: function()
     {
-        return this.contentElement();
+        if (this._formattedMessage)
+            return this._formattedMessage;
+        this._formattedMessage = createElementWithClass("span", "console-message-text source-code");
+        this._formattedMessage.textContent = this.text.replaceControlCharacters();
+        return this._formattedMessage;
     },
 
     /**
      * @override
      * @return {!Element}
      */
     contentElement: function()

[lushnikov, 2016/08/31 00:08:11]

can we switch to contentElement altogether? looks like there's no reason why it
shouldn't be possible

[luoe, 2016/08/31 17:52:02]

Done.

     {
         if (!this._element) {
             this._element = createElementWithClass("div", "console-user-command");
             this._element.message = this;
+            this._element.appendChild(this.formattedMessage());
 
-            this._formattedCommand = createElementWithClass("span", "console-message-text source-code");
-            this._formattedCommand.textContent = this.text.replaceControlCharacters();
-            this._element.appendChild(this._formattedCommand);
-
-            if (this._formattedCommand.textContent.length < WebInspector.ConsoleCommand.MaxLengthToIgnoreHighlighter) {
+            if (this._formattedMessage.textContent.length < WebInspector.ConsoleCommand.MaxLengthToIgnoreHighlighter) {
                 var javascriptSyntaxHighlighter = new WebInspector.DOMSyntaxHighlighter("text/javascript", true);
-                javascriptSyntaxHighlighter.syntaxHighlightNode(this._formattedCommand).then(this._updateSearch.bind(this))
+                javascriptSyntaxHighlighter.syntaxHighlightNode(this._formattedMessage).then(this._updateSearch.bind(this))
             } else {
                 this._updateSearch();
             }
         }
         return this._element;
     },
 
     _updateSearch: function()
     {
         this.setSearchRegex(this.searchRegex());
@@ skipping 140 matching lines @@
             return true;
         }
         return false;
     }
 }
 
 /**
 * @typedef {{messageIndex: number, matchIndex: number}}
 */
 WebInspector.ConsoleView.RegexMatchRange;