Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2270033003: DevTools: include traces when exporting console log via 'Save as' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 function writeNextChunk(stream, error) 650 function writeNextChunk(stream, error)
651 { 651 {
652 if (messageIndex >= this.itemCount() || error) { 652 if (messageIndex >= this.itemCount() || error) {
653 stream.close(); 653 stream.close();
654 progressIndicator.done(); 654 progressIndicator.done();
655 return; 655 return;
656 } 656 }
657 var lines = []; 657 var lines = [];
658 for (var i = 0; i < chunkSize && i + messageIndex < this.itemCount() ; ++i) { 658 for (var i = 0; i < chunkSize && i + messageIndex < this.itemCount() ; ++i) {
659 var message = this.itemElement(messageIndex + i); 659 var message = this.itemElement(messageIndex + i);
660 lines.push(message.searchableElement().deepTextContent()); 660 lines.push(message.formattedMessage().deepTextContent());
dgozman 2016/08/24 18:58:00 Do we need searchableElement anymore? Shouldn't se
luoe 2016/08/24 20:31:01 The only reason I can think might be users who don
661 } 661 }
662 messageIndex += i; 662 messageIndex += i;
663 stream.write(lines.join("\n") + "\n", writeNextChunk.bind(this)); 663 stream.write(lines.join("\n") + "\n", writeNextChunk.bind(this));
664 progressIndicator.setWorked(messageIndex); 664 progressIndicator.setWorked(messageIndex);
665 } 665 }
666 666
667 }, 667 },
668 668
669 /** 669 /**
670 * @param {!WebInspector.ConsoleViewMessage} lastMessage 670 * @param {!WebInspector.ConsoleViewMessage} lastMessage
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
1412 return true; 1412 return true;
1413 } 1413 }
1414 return false; 1414 return false;
1415 } 1415 }
1416 } 1416 }
1417 1417
1418 /** 1418 /**
1419 * @typedef {{messageIndex: number, matchIndex: number}} 1419 * @typedef {{messageIndex: number, matchIndex: number}}
1420 */ 1420 */
1421 WebInspector.ConsoleView.RegexMatchRange; 1421 WebInspector.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698