Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2270013002: Converted Observatory context-view element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed view structure #

Patch Set 3 : Fixed access to instance function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -110 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 4 chunks +34 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 1 1 chunk +177 lines, -10 lines 0 comments Download
D runtime/observatory/lib/src/elements/context_view.html View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/context.dart View 1 chunk +5 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/repositories/context.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/context.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 chunks +10 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 chunks +2 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/context/element_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/context/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/context.dart View 2 chunks +12 lines, -3 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/repositories/context.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-23 14:52:05 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-23 15:05:33 UTC) #3
Cutch
lgtm
4 years, 4 months ago (2016-08-23 18:07:38 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-23 20:15:19 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-23 20:16:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fc6954171eacc14e41c24b0ecda2a5c7fc3db320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698