Add unit test for UsbChooserController

chrome/browser/usb/usb_chooser_controller_unittest.cc

Index: chrome/browser/usb/usb_chooser_controller_unittest.cc
diff --git a/chrome/browser/usb/usb_chooser_controller_unittest.cc b/chrome/browser/usb/usb_chooser_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..05b9f342c62b89c282347c44e30cd0f65ddfd42b
--- /dev/null
+++ b/chrome/browser/usb/usb_chooser_controller_unittest.cc
@@ -0,0 +1,112 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/usb/usb_chooser_controller.h"
+#include "chrome/common/chrome_switches.h"
+#include "device/core/mock_device_client.h"
+#include "device/usb/mock_usb_device.h"
+#include "device/usb/mock_usb_service.h"
+#include "device/usb/public/interfaces/device_manager.mojom.h"
+#include "mojo/public/cpp/bindings/array.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class UsbChooserControllerTest : public testing::Test {
+ public:
+  UsbChooserControllerTest() {}
+  ~UsbChooserControllerTest() override = default;
+
+  void SetUp() override {
+    base::CommandLine::ForCurrentProcess()->AppendSwitch(
+        switches::kDisableWebUsbSecurity);

[Reilly Grant (use Gerrit), 2016/08/23 18:30:18]

I'm planning to remove this flag so I'd rather this test be written to use a
specific test domain.

[juncai, 2016/08/23 23:22:05]

Done.

+  }
+
+ protected:
+  device::MockDeviceClient device_client_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(UsbChooserControllerTest);
+};
+
+TEST_F(UsbChooserControllerTest, AddDevice) {
+  mojo::Array<device::usb::DeviceFilterPtr> device_filters;
+  device::usb::ChooserService::GetPermissionCallback callback;
+  UsbChooserController usb_chooser_controller(
+      nullptr, std::move(device_filters), nullptr, callback);
+
+  scoped_refptr<device::MockUsbDevice> device_a(
+      new device::MockUsbDevice(0, 1, "Google", "a", "001"));
+  device_client_.usb_service()->AddDevice(device_a);
+  EXPECT_EQ(1u, usb_chooser_controller.NumOptions());
+  EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller.GetOption(0));
+
+  scoped_refptr<device::MockUsbDevice> device_b(
+      new device::MockUsbDevice(0, 1, "Google", "b", "002"));
+  device_client_.usb_service()->AddDevice(device_b);
+  EXPECT_EQ(2u, usb_chooser_controller.NumOptions());
+  EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller.GetOption(1));
+
+  scoped_refptr<device::MockUsbDevice> device_c(
+      new device::MockUsbDevice(0, 1, "Google", "c", "003"));
+  device_client_.usb_service()->AddDevice(device_c);
+  EXPECT_EQ(3u, usb_chooser_controller.NumOptions());
+  EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller.GetOption(2));
+}
+
+TEST_F(UsbChooserControllerTest, RemoveDevice) {
+  mojo::Array<device::usb::DeviceFilterPtr> device_filters;
+  device::usb::ChooserService::GetPermissionCallback callback;
+  UsbChooserController usb_chooser_controller(
+      nullptr, std::move(device_filters), nullptr, callback);
+
+  scoped_refptr<device::MockUsbDevice> device_a(
+      new device::MockUsbDevice(0, 1, "Google", "a", "001"));
+  device_client_.usb_service()->AddDevice(device_a);
+  scoped_refptr<device::MockUsbDevice> device_b(
+      new device::MockUsbDevice(0, 1, "Google", "b", "002"));
+  device_client_.usb_service()->AddDevice(device_b);
+  scoped_refptr<device::MockUsbDevice> device_c(
+      new device::MockUsbDevice(0, 1, "Google", "c", "003"));
+  device_client_.usb_service()->AddDevice(device_c);
+
+  device_client_.usb_service()->RemoveDevice(device_b);
+  EXPECT_EQ(2u, usb_chooser_controller.NumOptions());
+  EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller.GetOption(0));
+  EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller.GetOption(1));
+
+  device_client_.usb_service()->RemoveDevice(device_a);
+  EXPECT_EQ(1u, usb_chooser_controller.NumOptions());
+  EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller.GetOption(0));
+
+  device_client_.usb_service()->RemoveDevice(device_c);
+  EXPECT_EQ(0u, usb_chooser_controller.NumOptions());
+}
+
+TEST_F(UsbChooserControllerTest, AddAndRemoveDeviceWithSameName) {
+  mojo::Array<device::usb::DeviceFilterPtr> device_filters;
+  device::usb::ChooserService::GetPermissionCallback callback;
+  UsbChooserController usb_chooser_controller(
+      nullptr, std::move(device_filters), nullptr, callback);
+
+  scoped_refptr<device::MockUsbDevice> device_a_1(
+      new device::MockUsbDevice(0, 1, "Google", "a", "001"));
+  device_client_.usb_service()->AddDevice(device_a_1);
+  EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller.GetOption(0));
+  scoped_refptr<device::MockUsbDevice> device_b(
+      new device::MockUsbDevice(0, 1, "Google", "b", "002"));
+  device_client_.usb_service()->AddDevice(device_b);
+  scoped_refptr<device::MockUsbDevice> device_a_2(
+      new device::MockUsbDevice(0, 1, "Google", "a", "002"));
+  device_client_.usb_service()->AddDevice(device_a_2);
+  EXPECT_EQ(base::ASCIIToUTF16("a (001)"), usb_chooser_controller.GetOption(0));
+  EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller.GetOption(1));
+  EXPECT_EQ(base::ASCIIToUTF16("a (002)"), usb_chooser_controller.GetOption(2));
+
+  device_client_.usb_service()->RemoveDevice(device_a_1);
+  EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller.GetOption(0));
+  EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller.GetOption(1));
+}