Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2269963005: Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium. (Closed)

Created:
4 years, 4 months ago by Jacob
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8ba1f007a93c9ee84305e4b5a7496f0e53b6e521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -0 lines) Patch
M lib/runtime/dart_sdk.js View 4 chunks +106 lines, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/lib/html/js_util_test.dart View 1 chunk +347 lines, -0 lines 0 comments Download
M tool/build_sdk.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tool/input_sdk/lib/_internal/libraries.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/js_util/dart2js/js_util_dart2js.dart View 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 4 months ago (2016-08-24 00:17:17 UTC) #2
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-24 00:39:33 UTC) #3
Jacob
4 years, 4 months ago (2016-08-24 16:13:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ba1f007a93c9ee84305e4b5a7496f0e53b6e521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698