chrome/browser/resources/settings/site_settings/add_site_dialog.js - Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.js

Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | chrome/browser/resources/settings/site_settings/site_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/add_site_dialog.js

diff --git a/chrome/browser/resources/settings/site_settings/add_site_dialog.js b/chrome/browser/resources/settings/site_settings/add_site_dialog.js

index c149df5e1f1769d0500f7ca7af5261e04de6c611..e7ceeed3a5363371a2980eb12ebdfa2e3e22affa 100644

--- a/chrome/browser/resources/settings/site_settings/add_site_dialog.js

+++ b/chrome/browser/resources/settings/site_settings/add_site_dialog.js

@@ -40,7 +40,7 @@ Polymer({

* @private

validate_: function() {

- var pattern = this.addPatternWildcard_(this.site_);

+ var pattern = this.addPatternWildcard(this.site_);

this.browserProxy.isPatternValid(pattern).then(function(isValid) {

this.$.add.disabled = !isValid;

}.bind(this));

@@ -59,7 +59,7 @@ Polymer({

onSubmit_: function() {

if (this.$.add.disabled)

return; // Can happen when Enter is pressed.

- var pattern = this.addPatternWildcard_(this.site_);

+ var pattern = this.addPatternWildcard(this.site_);

this.setCategoryPermissionForOrigin(

pattern, pattern, this.category, this.allowException ?

settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK);