Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2269953003: Add test cases for mouse hover on annotation. (Closed)

Created:
4 years, 3 months ago by jaepark
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test cases for mouse hover on annotation. The author and the content of the annotation must be shown when mouse hover on the annotation. R=dsinclair@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/5867fa68fa3e00016d3e31374e84eb01a3db6ac7

Patch Set 1 #

Patch Set 2 : Add test cases for mouse hover on annotation. #

Patch Set 3 : Add test cases for mouse hover on annotation. #

Patch Set 4 : Add test cases for mouse hover on annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A pdfium/annots/annotation_highlight_author_content.evt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + pdfium/annots/annotation_highlight_author_content.pdf View 1 2 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_author_content_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_long_content.evt View 1 chunk +1 line, -0 lines 0 comments Download
A + pdfium/annots/annotation_highlight_long_content.pdf View Binary file 0 comments Download
A pdfium/annots/annotation_highlight_long_content_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_no_author.evt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + pdfium/annots/annotation_highlight_no_author.pdf View 1 2 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_no_author_expected.pdf.0.png View 1 2 3 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_no_author_no_content.evt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + pdfium/annots/annotation_highlight_no_author_no_content.pdf View 1 2 Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_no_author_no_content_expected.pdf.0.png View 1 2 Binary file 0 comments Download
A pdfium/annots/annotation_highlight_no_content.evt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + pdfium/annots/annotation_highlight_no_content.pdf View 1 2 Binary file 0 comments Download
A + pdfium/annots/annotation_highlight_no_content_expected.pdf.0.png View 1 2 Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
jaepark
This is a visual output of https://codereview.chromium.org/2273893002/ .
4 years, 3 months ago (2016-08-23 22:30:53 UTC) #2
dsinclair
lgtm
4 years, 3 months ago (2016-08-24 18:56:38 UTC) #3
jaepark
Test cases are updated.
4 years, 3 months ago (2016-08-29 21:20:09 UTC) #4
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-29 22:41:20 UTC) #5
jaepark
4 years, 3 months ago (2016-08-29 23:13:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
5867fa68fa3e00016d3e31374e84eb01a3db6ac7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698