Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/unittests/value-serializer-unittest.cc

Issue 2269923004: Blink-compatible serialization of Map and Set objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: StackLimitCheck + HandleScope Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/value-serializer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/value-serializer-unittest.cc
diff --git a/test/unittests/value-serializer-unittest.cc b/test/unittests/value-serializer-unittest.cc
index 2db9776683ea0f53d96e42dc20fcc51ec235a533..7a8978ea8369a625784fefa94b3c5cf426b7dd37 100644
--- a/test/unittests/value-serializer-unittest.cc
+++ b/test/unittests/value-serializer-unittest.cc
@@ -1322,5 +1322,200 @@ TEST_F(ValueSerializerTest, DecodeRegExp) {
});
}
+TEST_F(ValueSerializerTest, RoundTripMap) {
+ RoundTripTest(
+ "(() => { var m = new Map(); m.set(42, 'foo'); return m; })()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Object.getPrototypeOf(result) === Map.prototype"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.get(42) === 'foo'"));
+ });
+ RoundTripTest("(() => { var m = new Map(); m.set(m, m); return m; })()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "result.get(result) === result"));
+ });
+ // Iteration order must be preserved.
+ RoundTripTest(
+ "(() => {"
+ " var m = new Map();"
+ " m.set(1, 0); m.set('a', 0); m.set(3, 0); m.set(2, 0);"
+ " return m;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '1,a,3,2'"));
+ });
+}
+
+TEST_F(ValueSerializerTest, DecodeMap) {
+ DecodeTest(
+ {0xff, 0x09, 0x3f, 0x00, 0x3b, 0x3f, 0x01, 0x49, 0x54, 0x3f, 0x01, 0x53,
+ 0x03, 0x66, 0x6f, 0x6f, 0x3a, 0x02},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Object.getPrototypeOf(result) === Map.prototype"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.get(42) === 'foo'"));
+ });
+ DecodeTest({0xff, 0x09, 0x3f, 0x00, 0x3b, 0x3f, 0x01, 0x5e, 0x00, 0x3f, 0x01,
+ 0x5e, 0x00, 0x3a, 0x02, 0x00},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "result.get(result) === result"));
+ });
+ // Iteration order must be preserved.
+ DecodeTest({0xff, 0x09, 0x3f, 0x00, 0x3b, 0x3f, 0x01, 0x49, 0x02, 0x3f,
+ 0x01, 0x49, 0x00, 0x3f, 0x01, 0x53, 0x01, 0x61, 0x3f, 0x01,
+ 0x49, 0x00, 0x3f, 0x01, 0x49, 0x06, 0x3f, 0x01, 0x49, 0x00,
+ 0x3f, 0x01, 0x49, 0x04, 0x3f, 0x01, 0x49, 0x00, 0x3a, 0x08},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '1,a,3,2'"));
+ });
+}
+
+TEST_F(ValueSerializerTest, RoundTripMapWithTrickyGetters) {
+ // Even if an entry is removed or reassigned, the original key/value pair is
+ // used.
+ RoundTripTest(
+ "(() => {"
+ " var m = new Map();"
+ " m.set(0, { get a() {"
+ " m.delete(1); m.set(2, 'baz'); m.set(3, 'quux');"
+ " }});"
+ " m.set(1, 'foo');"
+ " m.set(2, 'bar');"
+ " return m;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '0,1,2'"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.get(1) === 'foo'"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.get(2) === 'bar'"));
+ });
+ // However, deeper modifications of objects yet to be serialized still apply.
+ RoundTripTest(
+ "(() => {"
+ " var m = new Map();"
+ " var key = { get a() { value.foo = 'bar'; } };"
+ " var value = { get a() { key.baz = 'quux'; } };"
+ " m.set(key, value);"
+ " return m;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsMap());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "!('baz' in Array.from(result.keys())[0])"));
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.values())[0].foo === 'bar'"));
+ });
+}
+
+TEST_F(ValueSerializerTest, RoundTripSet) {
+ RoundTripTest(
+ "(() => { var s = new Set(); s.add(42); s.add('foo'); return s; })()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Object.getPrototypeOf(result) === Set.prototype"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 2"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has(42)"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has('foo')"));
+ });
+ RoundTripTest(
+ "(() => { var s = new Set(); s.add(s); return s; })()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has(result)"));
+ });
+ // Iteration order must be preserved.
+ RoundTripTest(
+ "(() => {"
+ " var s = new Set();"
+ " s.add(1); s.add('a'); s.add(3); s.add(2);"
+ " return s;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '1,a,3,2'"));
+ });
+}
+
+TEST_F(ValueSerializerTest, DecodeSet) {
+ DecodeTest({0xff, 0x09, 0x3f, 0x00, 0x27, 0x3f, 0x01, 0x49, 0x54, 0x3f, 0x01,
+ 0x53, 0x03, 0x66, 0x6f, 0x6f, 0x2c, 0x02},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Object.getPrototypeOf(result) === Set.prototype"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 2"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has(42)"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has('foo')"));
+ });
+ DecodeTest(
+ {0xff, 0x09, 0x3f, 0x00, 0x27, 0x3f, 0x01, 0x5e, 0x00, 0x2c, 0x01, 0x00},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.size === 1"));
+ EXPECT_TRUE(EvaluateScriptForResultBool("result.has(result)"));
+ });
+ // Iteration order must be preserved.
+ DecodeTest(
+ {0xff, 0x09, 0x3f, 0x00, 0x27, 0x3f, 0x01, 0x49, 0x02, 0x3f, 0x01, 0x53,
+ 0x01, 0x61, 0x3f, 0x01, 0x49, 0x06, 0x3f, 0x01, 0x49, 0x04, 0x2c, 0x04},
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '1,a,3,2'"));
+ });
+}
+
+TEST_F(ValueSerializerTest, RoundTripSetWithTrickyGetters) {
+ // Even if an element is added or removed during serialization, the original
+ // set of elements is used.
+ RoundTripTest(
+ "(() => {"
+ " var s = new Set();"
+ " s.add({ get a() { s.delete(1); s.add(2); } });"
+ " s.add(1);"
+ " return s;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys()).toString() === '[object Object],1'"));
+ });
+ // However, deeper modifications of objects yet to be serialized still apply.
+ RoundTripTest(
+ "(() => {"
+ " var s = new Set();"
+ " var first = { get a() { second.foo = 'bar'; } };"
+ " var second = { get a() { first.baz = 'quux'; } };"
+ " s.add(first);"
+ " s.add(second);"
+ " return s;"
+ "})()",
+ [this](Local<Value> value) {
+ ASSERT_TRUE(value->IsSet());
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "!('baz' in Array.from(result.keys())[0])"));
+ EXPECT_TRUE(EvaluateScriptForResultBool(
+ "Array.from(result.keys())[1].foo === 'bar'"));
+ });
+}
+
} // namespace
} // namespace v8
« no previous file with comments | « src/value-serializer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698