Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2269923004: Blink-compatible serialization of Map and Set objects. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of Map and Set objects. BUG=chromium:148757 Committed: https://crrev.com/78131aa1d5e23e0ae9888912fa96ee6ec9624fd9 Cr-Commit-Position: refs/heads/master@{#38871}

Patch Set 1 #

Patch Set 2 : StackLimitCheck + HandleScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -0 lines) Patch
M src/value-serializer.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 5 chunks +150 lines, -0 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +195 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jbroman
4 years, 4 months ago (2016-08-23 18:25:34 UTC) #6
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-24 15:11:44 UTC) #7
jbroman
Just realized that I'd omitted the requisite StackLimitCheck+HandleScope for these which, like JSObject and JSArray, ...
4 years, 4 months ago (2016-08-24 15:19:45 UTC) #10
Jakob Kummerow
LGTM. Sorry I missed that in the review.
4 years, 4 months ago (2016-08-24 15:36:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269923004/20001
4 years, 4 months ago (2016-08-24 15:37:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 15:58:42 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 15:59:00 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78131aa1d5e23e0ae9888912fa96ee6ec9624fd9
Cr-Commit-Position: refs/heads/master@{#38871}

Powered by Google App Engine
This is Rietveld 408576698