Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2269883002: Refactor textTractDisplayElement utility function (Closed)

Created:
4 years, 3 months ago by Srirama
Modified:
4 years, 3 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor textTrackDisplayElement utility function Added new functions textTrackRegionElement and textTrackRegionContainerElement for specific usages instead of using textTrackDisplayElement. Committed: https://crrev.com/d5f493725052a09d24002b96a34d9e092bfe1aaa Cr-Commit-Position: refs/heads/master@{#413705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/media/media-controls.js View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-display.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Srirama
4 years, 3 months ago (2016-08-23 05:32:28 UTC) #4
fs
lgtm
4 years, 3 months ago (2016-08-23 08:17:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269883002/1
4 years, 3 months ago (2016-08-23 08:38:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-23 10:13:55 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 10:15:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5f493725052a09d24002b96a34d9e092bfe1aaa
Cr-Commit-Position: refs/heads/master@{#413705}

Powered by Google App Engine
This is Rietveld 408576698