chrome/browser/safe_browsing/permission_reporter_browsertest.cc - Issue 2269863002: Turn on Permission Action Reporting by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Issue 2269863002: Turn on Permission Action Reporting by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-disable test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

diff --git a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

index 0a13f644aab0ee720cbfed5d029cf91740386e1b..dcf8bcc1caa57d246d05f59a1a2ea751ddd41d0f 100644

--- a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

+++ b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc

@@ -61,10 +61,6 @@ class PermissionReporterBrowserTest : public InProcessBrowserTest {

mock_permission_prompt_factory_.reset();

}

- void SetUpCommandLine(base::CommandLine* command_line) override {

- command_line->AppendSwitch(switches::kEnablePermissionActionReporting);

- }

void AttachMockReportSenderOnIOThread(

scoped_refptr<SafeBrowsingService> safe_browsing_service) {

DCHECK_CURRENTLY_ON(content::BrowserThread::IO);