chrome/browser/permissions/permission_uma_util.cc - Issue 2269863002: Turn on Permission Action Reporting by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2269863002: Turn on Permission Action Reporting by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-disable test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index abf5fb45f7d84857a9c82f94014620deac6257fb..52c3ca888e8144e5ccc3253c4e855ace52dd1966 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -568,8 +568,8 @@ void PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle(

}

bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {

- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnablePermissionActionReporting))

+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kDisablePermissionActionReporting))

raymes 2016/08/23 08:18:35 nit: add {}

kcarattini 2016/08/24 03:23:36 Done.

return false;

DCHECK(profile);

« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util_unittest.cc » ('j') | no next file with comments »