third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h - Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h

Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: replaced ->Set( in v8_inspector Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h b/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h

index 9cd650cc80168bb4f8379cb44dd6000881deeab7..865b824eb013ccd8c2a3f3eac996a74bd16e0ef3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h

@@ -10,6 +10,8 @@

namespace v8_inspector {

v8::MaybeLocal<v8::Value> copyValueFromDebuggerContext(v8::Isolate*, v8::Local<v8::Context> debuggerContext, v8::Local<v8::Context> toContext, v8::Local<v8::Value>);

+v8::Maybe<bool> safeCreateDataProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, v8::Local<v8::Name> key, v8::Local<v8::Value>);

+v8::Maybe<bool> safeCreateDataProperty(v8::Local<v8::Context>, v8::Local<v8::Array>, int index, v8::Local<v8::Value>);

} // namespace v8_inspector