Issue 226983002: Mojo: Mojom: Test the parser when there's no module declared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226983002: Mojo: Mojom: Test the parser when there's no module declared. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Test the parser when there's no module declared. Also make sure that it handles this differently from a missing module name (and test that it detects that error correctly). (And fix line number tracking/reporting in the parser....) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262254

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -7 lines)			Patch
M	mojo/public/tools/bindings/pylib/parse/mojo_lexer.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/tools/bindings/pylib/parse/mojo_parser.py	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/parse/mojo_parser_unittest.py	View	3 chunks	+48 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/226983002/1

6 years, 8 months ago (2014-04-07 21:31:59 UTC) #5

viettrungluu

6 years, 8 months ago (2014-04-07 23:51:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r262254 (presubmit successful).

Expand Messages | Collapse Messages