Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2269803002: [DevTools] Fix standalone V8 Inspector build (Closed)

Created:
4 years, 4 months ago by eostroukhov
Modified:
4 years, 4 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix standalone V8 Inspector build R=dgozman@chromium.org BUG= Committed: https://crrev.com/47e6601eb43729f0e1628ab0004b0e394c8e6f6e Cr-Commit-Position: refs/heads/master@{#413610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
eostroukhov-old
Please take a look
4 years, 4 months ago (2016-08-22 23:26:56 UTC) #3
eostroukhov
4 years, 4 months ago (2016-08-22 23:27:34 UTC) #5
dgozman
Thanks! My bad. lgtm
4 years, 4 months ago (2016-08-22 23:28:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269803002/1
4 years, 4 months ago (2016-08-22 23:34:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 00:55:42 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:57:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e6601eb43729f0e1628ab0004b0e394c8e6f6e
Cr-Commit-Position: refs/heads/master@{#413610}

Powered by Google App Engine
This is Rietveld 408576698