Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2269783004: Activate a TextInputManager test on Mac OSX. (Closed)

Created:
4 years, 4 months ago by EhsanK
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Activate a TextInputManager test on Mac OSX. TextInputManager now collects IME and TextInputState for OOPIF on Mac OSX. The enabled test now passes on Mac. BUG=578168, 602723 Committed: https://crrev.com/82b2adfb3119d1bad8322ce0ff0d81d62ea6ca5b Cr-Commit-Position: refs/heads/master@{#413920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
EhsanK
PTAL.
4 years, 4 months ago (2016-08-23 22:15:02 UTC) #4
Charlie Reis
LGTM!
4 years, 4 months ago (2016-08-24 01:02:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269783004/1
4 years, 4 months ago (2016-08-24 01:03:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 01:08:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 01:11:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82b2adfb3119d1bad8322ce0ff0d81d62ea6ca5b
Cr-Commit-Position: refs/heads/master@{#413920}

Powered by Google App Engine
This is Rietveld 408576698