chrome/test/data/webui/settings/people_page_manage_profile_test.js - Issue 2269743002: Profile Avatar Selector: Allow arrow keys to be used for moving between avatars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/people_page_manage_profile_test.js

Issue 2269743002: Profile Avatar Selector: Allow arrow keys to be used for moving between avatars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/cr_elements/cr_profile_avatar_selector_tests.js ('k') | ui/webui/resources/cr_elements/cr_profile_avatar_selector/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/people_page_manage_profile_test.js

diff --git a/chrome/test/data/webui/settings/people_page_manage_profile_test.js b/chrome/test/data/webui/settings/people_page_manage_profile_test.js

index 432b448c2c86e687b167974e06f60be41b8211d0..6d9fd3e2310ba13527820a26915d8a14f9930b1a 100644

--- a/chrome/test/data/webui/settings/people_page_manage_profile_test.js

+++ b/chrome/test/data/webui/settings/people_page_manage_profile_test.js

@@ -53,7 +53,7 @@ cr.define('settings_people_page_manage_profile', function() {

// - has the correct icon selected

// - can select a new icon

test('ManageProfileChangeIcon', function() {

- var selector = manageProfile.$.selector.$.selector;

+ var selector = manageProfile.$.selector.$['avatar-grid'];

assertTrue(!!selector);

return browserProxy.whenCalled('getAvailableIcons').then(function() {

@@ -75,7 +75,7 @@ cr.define('settings_people_page_manage_profile', function() {

// Tests profile icon updates pushed from the browser.

test('ManageProfileIconUpdated', function() {

- var selector = manageProfile.$.selector.$.selector;

+ var selector = manageProfile.$.selector.$['avatar-grid'];

assertTrue(!!selector);

return browserProxy.whenCalled('getAvailableIcons').then(function() {