Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: runtime/vm/heap.h

Issue 226973003: Simpler, more consistent triggering of old GC; also, use external in policy. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/heap.h
===================================================================
--- runtime/vm/heap.h (revision 35145)
+++ runtime/vm/heap.h (working copy)
@@ -48,7 +48,7 @@
enum GCReason {
kNewSpace,
- kPromotionFailure,
+ kPromotion,
kOldSpace,
kFull,
kGCAtAlloc,
@@ -106,6 +106,8 @@
// Track external data.
void AllocateExternal(intptr_t size, Space space);
void FreeExternal(intptr_t size, Space space);
+ // Move external size from new to old space. Does not by itself trigger GC.
+ void PromoteExternal(intptr_t size);
// Heap contains the specified address.
bool Contains(uword addr) const;
@@ -142,7 +144,7 @@
RawObject* FindObject(FindObjectVisitor* visitor) const;
void CollectGarbage(Space space);
- void CollectGarbage(Space space, ApiCallbacks api_callbacks);
+ void CollectGarbage(Space space, ApiCallbacks api_callbacks, GCReason reason);
void CollectAllGarbage();
// Enables growth control on the page space heaps. This should be

Powered by Google App Engine
This is Rietveld 408576698