Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: runtime/vm/pages.h

Issue 226973003: Simpler, more consistent triggering of old GC; also, use external in policy. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/pages.h
===================================================================
--- runtime/vm/pages.h (revision 35145)
+++ runtime/vm/pages.h (working copy)
@@ -199,7 +199,8 @@
GrowthPolicy growth_policy = kControlGrowth);
bool NeedsGarbageCollection() const {
- return page_space_controller_.NeedsGarbageCollection(usage_);
+ return page_space_controller_.NeedsGarbageCollection(usage_) ||
+ NeedsExternalGC();
}
intptr_t UsedInWords() const { return usage_.used_in_words; }
@@ -242,7 +243,7 @@
return page_space_controller_.is_enabled();
}
- bool NeedExternalGC() {
+ bool NeedsExternalGC() const {
return UsedInWords() + ExternalInWords() > max_capacity_in_words_;
}

Powered by Google App Engine
This is Rietveld 408576698