Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2269693002: Implement parsing support for generic functions (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement parsing support for generic functions Take two. (This version adds status file entries for checked tests.) Type parameters and arguments are parsed but ignored. Proper handling of the parameters will be added subsequently. The feature must be enabled with --generic-method-syntax. Compiling all of dart2js consumes about 2.2% more tokens with this change, due to the necessary lookahead to distinguish generic functions from generic types. ===== with this change ========= Number of tokens: 1056691 Source length: 5850143 characters Number of source tokens: 936226 Total tokens consumed: 3628934 <<<<< Classes parsed: 2457 Tokens consumed: 977999 Functions parsed: 49607 Tokens consumed: 2430638 ===== without this change ====== Number of tokens: 1056691 Source length: 5850143 characters Number of source tokens: 936226 Total tokens consumed: 3547765 <<<<< Classes parsed: 2457 Tokens consumed: 942536 Functions parsed: 49607 Tokens consumed: 2371357 (This reverts commit a1edb1766fd16b1268f3506feb7c9856b32bedfc.) BUG=25869 Committed: https://github.com/dart-lang/sdk/commit/4d4ebafad3f735b3d69360370b163f4e79d229ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -128 lines) Patch
M runtime/vm/parser.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 28 chunks +300 lines, -114 lines 0 comments Download
M tests/language/generic_functions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_function_type_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_new_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_methods_type_expression_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 4 months ago (2016-08-22 16:23:11 UTC) #3
hausner
Committed patchset #1 (id:1) manually as 4d4ebafad3f735b3d69360370b163f4e79d229ba (presubmit successful).
4 years, 4 months ago (2016-08-22 17:59:00 UTC) #5
hausner
4 years, 4 months ago (2016-08-22 17:59:34 UTC) #6
Message was sent while issue was closed.
TBR=asiva

Powered by Google App Engine
This is Rietveld 408576698