Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2269683002: Remove more references to FileBasedSource (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -64 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 2 chunks +11 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +10 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 9 chunks +27 lines, -26 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 5 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-22 15:58:45 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-22 18:43:58 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-22 20:33:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7d246013020be94aa51052a76adc208af6a2473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698