appengine/swarming/elements/res/js/common.js - Issue 2269643002: Extract shared filters and aliasing code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/elements/res/js/common.js

Issue 2269643002: Extract shared filters and aliasing code (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: Address nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/swarming/elements/res/js/common.js

diff --git a/appengine/swarming/elements/res/js/common.js b/appengine/swarming/elements/res/js/common.js

index e0da135d8873721d1ae719b6e0d25c92ba5515c0..f0639e6f525523c2cad3df582871e665e0b824c8 100644

--- a/appengine/swarming/elements/res/js/common.js

+++ b/appengine/swarming/elements/res/js/common.js

@@ -47,7 +47,7 @@ this.swarming = this.swarming || function() {

if (!isNaN(ns)) {

return ns;

}

- return a.localeCompare(b);

+ return String(a).localeCompare(b);

};

return swarming;

« no previous file with comments | « appengine/swarming/elements/res/js/alias.js ('k') | no next file » | no next file with comments »