Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2269633002:
Add StartCom log to list of known CT Logs (Closed)
|
Created:
4 years, 4 months ago by Martin Smith Modified:
4 years, 3 months ago CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, davidben Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd StartCom log to list of known CT Logs
BUG=611672
Committed: https://crrev.com/19ad77688a08480a7641d621787525ad336cbe69
Cr-Commit-Position: refs/heads/master@{#414440}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add missing trailing / #
Total comments: 3
Patch Set 3 : Fix conflicts with prior WoSign log addition #Messages
Total messages: 22 (9 generated)
Adds StartCom log to CT logs list It has recently successfully completed its 90d compliance monitoring period. Inclusion request: https://crbug.com/611672
Description was changed from ========== Add StartCom log to list of known CT Logs BUG= ========== to ========== Add StartCom log to list of known CT Logs BUG=611672 ==========
mhs@google.com changed reviewers: + davidben@chromium.org
robpercival@chromium.org changed reviewers: + robpercival@chromium.org
https://codereview.chromium.org/2269633002/diff/1/net/cert/ct_known_logs_stat... File net/cert/ct_known_logs_static-inc.h (right): https://codereview.chromium.org/2269633002/diff/1/net/cert/ct_known_logs_stat... net/cert/ct_known_logs_static-inc.h:121: 91, "StartCom CT log", "https://ct.startssl.com", All of the other log URLs have a trailing slash. It's probably best to stick to that convention.
On 2016/08/23 09:41:51, Rob Percival wrote: > https://codereview.chromium.org/2269633002/diff/1/net/cert/ct_known_logs_stat... > File net/cert/ct_known_logs_static-inc.h (right): > > https://codereview.chromium.org/2269633002/diff/1/net/cert/ct_known_logs_stat... > net/cert/ct_known_logs_static-inc.h:121: 91, "StartCom CT log", > "https://ct.startssl.com", > All of the other log URLs have a trailing slash. It's probably best to stick to > that convention. Done.
davidben@chromium.org changed reviewers: + rsleevi@chromium.org
s/davidben/rsleevi/ since I know little of the various processes around this stuff.
rsleevi@chromium.org changed reviewers: - davidben@chromium.org
Removing David and assigning back to me.
On 2016/08/23 15:34:10, Ryan Sleevi (slow) wrote: > Removing David and assigning back to me. Oh, I missed David did that, thanks :)
LGTM, but you'll run into conflicts with https://codereview.chromium.org/2202823003/ so please coordinate with Rob on landing https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... File net/cert/ct_known_logs_static-inc.h (right): https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... net/cert/ct_known_logs_static-inc.h:122: "startcom1.ct.googleapis.com"}}; Why this prefix?
https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... File net/cert/ct_known_logs_static-inc.h (right): https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... net/cert/ct_known_logs_static-inc.h:122: "startcom1.ct.googleapis.com"}}; On 2016/08/25 04:12:49, Ryan Sleevi (slow) wrote: > Why this prefix? That's what was configured when DNS was brought up. AFAIK their company name is StartCom so probably seemed better than startssl.
The CQ bit was checked by mhs@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org Link to the patchset: https://codereview.chromium.org/2269633002/#ps40001 (title: "Fix conflicts with prior WoSign log addition")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add StartCom log to list of known CT Logs BUG=611672 ========== to ========== Add StartCom log to list of known CT Logs BUG=611672 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add StartCom log to list of known CT Logs BUG=611672 ========== to ========== Add StartCom log to list of known CT Logs BUG=611672 Committed: https://crrev.com/19ad77688a08480a7641d621787525ad336cbe69 Cr-Commit-Position: refs/heads/master@{#414440} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/19ad77688a08480a7641d621787525ad336cbe69 Cr-Commit-Position: refs/heads/master@{#414440}
Message was sent while issue was closed.
https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... File net/cert/ct_known_logs_static-inc.h (right): https://codereview.chromium.org/2269633002/diff/20001/net/cert/ct_known_logs_... net/cert/ct_known_logs_static-inc.h:122: "startcom1.ct.googleapis.com"}}; On 2016/08/25 09:31:22, Martin Smith wrote: > On 2016/08/25 04:12:49, Ryan Sleevi (slow) wrote: > > Why this prefix? > > That's what was configured when DNS was brought up. AFAIK their company name is > StartCom so probably seemed better than startssl. Apologies for not being clearer: Why startcom*1* (the numeral one), when no other log has such a numbering system. |
