SkPDF: paths as rects when possible

src/pdf/SkPDFUtils.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkData.h"
 #include "SkFixed.h"
@@ skipping 104 matching lines @@
     content->writeText(" re\n");
 }
 
 // static
 void SkPDFUtils::EmitPath(const SkPath& path, SkPaint::Style paintStyle,
                           bool doConsumeDegerates, SkWStream* content) {
     // Filling a path with no area results in a drawing in PDF renderers but
     // Chrome expects to be able to draw some such entities with no visible
     // result, so we detect those cases and discard the drawing for them.
     // Specifically: moveTo(X), lineTo(Y) and moveTo(X), lineTo(X), lineTo(Y).
+
+    SkRect rect;
+    bool isClosed;
+    SkPath::Direction direction;
+    if (path.isRect(&rect, &isClosed, &direction)) {
+        if (isClosed && SkPath::kCW_Direction == direction) {

[bungeman-skia, 2016/08/22 19:28:18]

Is the check for CW really needed? What's the output if CCW? Mostly just
curious.

+            //SkPDFUtils::AppendRectangle(rect, content);

[bungeman-skia, 2016/08/22 19:28:18]

Either this should be written and used or the comment removed.

+            SkPDFUtils::AppendScalar(rect.left(), content);
+            content->writeText(" ");
+            SkPDFUtils::AppendScalar(rect.top(), content);
+            content->writeText(" ");
+            SkPDFUtils::AppendScalar(rect.width(), content);
+            content->writeText(" ");
+            SkPDFUtils::AppendScalar(rect.height(), content);
+            content->writeText(" re\n");
+            return;
+        }
+    }
+
     enum SkipFillState {
         kEmpty_SkipFillState,
         kSingleLine_SkipFillState,
         kNonSingleLine_SkipFillState,
     };
     SkipFillState fillState = kEmpty_SkipFillState;
     //if (paintStyle != SkPaint::kFill_Style) {
     //    fillState = kNonSingleLine_SkipFillState;
     //}
     SkPoint lastMovePt = SkPoint::Make(0,0);
@@ skipping 337 matching lines @@
             uint8_t c = static_cast<uint8_t>(cin[i]);
             static const char gHex[] = "0123456789ABCDEF";
             char hexValue[2];
             hexValue[0] = gHex[(c >> 4) & 0xF];
             hexValue[1] = gHex[ c       & 0xF];
             wStream->write(hexValue, 2);
         }
         wStream->writeText(">");
     }
 }