Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2269543003: Minor cosmetic changes (Closed)

Created:
4 years, 4 months ago by Raymond Toy
Modified:
4 years, 4 months ago
Reviewers:
hongchan
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cosmetic changes First, use %16p in debugging prints in offline context so that the context address lines up with other uses of the address. Second, add numbers to the AudioNode:NodeType enum. I'm tired of counting every time I need to look up a node number when DEBUG_AUDIONODE_REFERENCES is enabled. BUG= TESTS= Committed: https://crrev.com/acbd9fd3613c68a3505aeccf301dbd10b0258e9b Cr-Commit-Position: refs/heads/master@{#413467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Raymond Toy
PTAL at this really simple CL.
4 years, 4 months ago (2016-08-22 15:52:23 UTC) #2
hongchan
lgtm
4 years, 4 months ago (2016-08-22 15:53:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269543003/1
4 years, 4 months ago (2016-08-22 15:55:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 17:29:32 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:32:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acbd9fd3613c68a3505aeccf301dbd10b0258e9b
Cr-Commit-Position: refs/heads/master@{#413467}

Powered by Google App Engine
This is Rietveld 408576698