Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 226953004: Remove get/set currentPath in canvas (Closed)

Created:
6 years, 8 months ago by zino
Modified:
6 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, Rik, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove get/set currentPath in canvas currentPath is not the right way to apply a Path2D object to a context. Main argument is that currentPath creates a copy of the Path2D object. Instead we pass Path2D as argument to fill, stroke and clip now. (The way isn't defined in the w3c specification as well) Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6l01Mv3VND0 BUG=362962 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173073

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -261 lines) Patch
D LayoutTests/fast/canvas/canvas-currentPath.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-currentPath-crash.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-currentPath-crash-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-currentPath-expected.txt View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-currentPath.js View 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-currentPath-crash.js View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js View 1 5 chunks +5 lines, -10 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-path-constructors.js View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Justin Novosad
lgtm
6 years, 8 months ago (2014-04-16 20:38:30 UTC) #1
zino
Ping @eseidel. This CL needs API owner's approval. I already sent the intent to deprecate ...
6 years, 7 months ago (2014-04-30 11:23:19 UTC) #2
eseidel
lgtm
6 years, 7 months ago (2014-04-30 23:01:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/226953004/20001
6 years, 7 months ago (2014-04-30 23:02:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 23:32:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 23:32:10 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 7 months ago (2014-05-01 08:17:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/226953004/40001
6 years, 7 months ago (2014-05-01 08:18:07 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 09:25:46 UTC) #9
Message was sent while issue was closed.
Change committed as 173073

Powered by Google App Engine
This is Rietveld 408576698