Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2269523003: Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. (Closed)

Created:
4 years, 4 months ago by Łukasz Anforowicz
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, alexmos, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. BUG=639510 Committed: https://crrev.com/a98073ac85514395939268f9d71a5d609867d450 Cr-Commit-Position: refs/heads/master@{#413773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +2 lines, -1 line 0 comments Download
A testing/buildbot/filters/isolate-extensions.interactive_ui_tests.filter View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Łukasz Anforowicz
Charlie, can you take a look please?
4 years, 4 months ago (2016-08-22 19:07:51 UTC) #2
Charlie Reis
Ah, that's too bad that we need to introduce a new filter file for this ...
4 years, 4 months ago (2016-08-22 20:00:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269523003/1
4 years, 4 months ago (2016-08-23 16:24:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 17:28:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a98073ac85514395939268f9d71a5d609867d450 Cr-Commit-Position: refs/heads/master@{#413773}
4 years, 4 months ago (2016-08-23 17:31:31 UTC) #8
Łukasz Anforowicz
4 years, 3 months ago (2016-08-26 21:54:25 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2287743002/ by lukasza@chromium.org.

The reason for reverting is: The filter file is apparently not needed anymore:
despite the fact that the test got renamed in r413759, we are not seeing
failures in the WindowOpenFocus test in the latest builds on Site Isolation Win
bot..

Powered by Google App Engine
This is Rietveld 408576698