Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h

Issue 2269513002: Use per-frame task runner in XHR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make XHRPT own a clone of WebTaskRunner Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
index 23ceb9c58399646bf4226f08b0293d222b46676d..7732051b3d22767ce50876e8db1703423764deb1 100644
--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h
@@ -50,10 +50,7 @@ class XMLHttpRequest;
// the spec.
class XMLHttpRequestProgressEventThrottle final : public GarbageCollectedFinalized<XMLHttpRequestProgressEventThrottle>, public TimerBase {
public:
- static XMLHttpRequestProgressEventThrottle* create(XMLHttpRequest* eventTarget)
- {
- return new XMLHttpRequestProgressEventThrottle(eventTarget);
- }
+ static XMLHttpRequestProgressEventThrottle* create(XMLHttpRequest* eventTarget);
~XMLHttpRequestProgressEventThrottle() override;
enum DeferredEventAction {
@@ -85,7 +82,7 @@ public:
DECLARE_TRACE();
private:
- explicit XMLHttpRequestProgressEventThrottle(XMLHttpRequest*);
+ XMLHttpRequestProgressEventThrottle(XMLHttpRequest*, std::unique_ptr<WebTaskRunner>);
// Dispatches a "progress" progress event and usually a readyStateChange
// event as well.
@@ -112,6 +109,7 @@ private:
void fired() override;
+ std::unique_ptr<WebTaskRunner> m_taskRunner;
yhirano 2016/08/25 04:28:25 Please add some comments describing why this is ne
tzik 2016/08/29 02:08:59 Done.
Member<XMLHttpRequest> m_target;
// A slot for the deferred "progress" ProgressEvent. When multiple events

Powered by Google App Engine
This is Rietveld 408576698