Permission Action Reporting: Make the browsertest work with SyncTest framework.

Permission Action Reporting: Make the browsertest work with SyncTest framework.

BUG=613883
Committed: https://crrev.com/49450fe932b6cf12caa89354045a6c9d5269e677
Cr-Commit-Position: refs/heads/master@{#413999}

[kcarattini, 2016-08-22 04:35:59]

kcarattini@chromium.org changed reviewers:
+ nparker@chromium.org, pavely@chromium.org

[pavely, 2016-08-22 18:00:12]

lgtm

[Nathan Parker, 2016-08-24 05:19:19]

lgtm

https://codereview.chromium.org/2269503002/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2269503002/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:99:
PermissionRequestManager* manager = GetPermissionRequestManager(browser);
I'm not familiar with where this should be done (here or in SetUp, or
SetUpOnMainThread), but if this works, LGTM.

[kcarattini, 2016-08-24 06:00:12]

Thanks!

https://codereview.chromium.org/2269503002/diff/20001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2269503002/diff/20001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:99:
PermissionRequestManager* manager = GetPermissionRequestManager(browser);
On 2016/08/24 05:19:19, Nathan Parker wrote:
> I'm not familiar with where this should be done (here or in SetUp, or
> SetUpOnMainThread), but if this works, LGTM.

The reason I moved this was that the fake profile that is set up in SyncTest
doesn't happen until the SetupSync call, and I need all this to use the browser
object that is created with that fake profile. Maybe it's not the cleanest, but
it works :).

[kcarattini, 2016-08-24 06:00:31]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2016-08-24 06:01:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 06:56:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 06:57:59]

Description was changed from

==========
Permission Action Reporting: Make the browsertest work with SyncTest framework.

BUG=613883
==========

to

==========
Permission Action Reporting: Make the browsertest work with SyncTest framework.

BUG=613883

Committed: https://crrev.com/49450fe932b6cf12caa89354045a6c9d5269e677
Cr-Commit-Position: refs/heads/master@{#413999}
==========

[commit-bot: I haz the power, 2016-08-24 06:58:01]

Patchset 2 (id:??) landed as
https://crrev.com/49450fe932b6cf12caa89354045a6c9d5269e677
Cr-Commit-Position: refs/heads/master@{#413999}