Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: chrome/browser/resources/feedback.js

Issue 22695004: Attach performance tracing data to feedback reports (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index c5e183eabeac2a159aea262adc05c57b5e66beda..97ebf3d9943d25b7184c2fc9ccae28c1759d9fd2 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -18,6 +18,7 @@ savedThumbnailIds['saved-screenshots'] = '';
var categoryTag = '';
var filePath = '';
var forceDisableScreenshots = false;
+var traceId = 0;
// Globals to manage reading data from the attach a file option.
var attachFileBinaryData = '';
@@ -184,6 +185,11 @@ function sendReport() {
// Add chromeos data if it exists.
if ($('sys-info-checkbox')) {
reportArray = reportArray.concat([String($('sys-info-checkbox').checked)]);
+ console.log(traceId);
rkc 2013/08/09 21:15:44 Do we want this log? If so, might want to prepend
Zachary Kuznia 2013/08/09 21:45:28 Leftover debugging. Removed.
+ if (!$('performance-info-checkbox').checked) {
+ traceId = 0;
+ }
+ reportArray = reportArray.concat([String(traceId)]);
}
if ($('attach-file-checkbox') &&
@@ -304,6 +310,9 @@ function load() {
'categoryTag': '',
'customPageUrl': '',
'filePath': '',
+<if expr="pp_ifdef('chromeos')">
rkc 2013/08/09 21:15:44 We don't need the <if expr.. here, having the extr
Zachary Kuznia 2013/08/09 21:45:28 Done.
+ 'traceId': 0,
+</if>
};
var loc = window.location;
@@ -357,6 +366,14 @@ function load() {
}
}
+<if expr="pp_ifdef('chromeos')">
rkc 2013/08/09 21:15:44 Same, we can leave this code in non-chromeOS also.
Zachary Kuznia 2013/08/09 21:45:28 Done.
+ traceId = parameters['traceId'];
+ console.log(traceId);
rkc 2013/08/09 21:15:44 Same as above, either prepend a description to the
Zachary Kuznia 2013/08/09 21:45:28 Done.
+ if (traceId != 0) {
+ $('performance-info-area').hidden = false;
+ }
+</if>
+
chrome.send('getDialogDefaults');
chrome.send('refreshCurrentScreenshot');
}

Powered by Google App Engine
This is Rietveld 408576698