Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2269493002: Add custom elements in imports ordering tests. (Closed)

Created:
4 years, 4 months ago by kochi
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, kojii, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add custom elements in imports ordering tests. This makes sure order of script execution in HTML imports, which define custom elements. BUG=594918 Committed: https://crrev.com/29016e7c9d34b097f40a53c8e5e709ef1aced2cb Cr-Commit-Position: refs/heads/master@{#413419}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Grammer fix #

Messages

Total messages: 18 (11 generated)
kochi
Dominic, This CL was spun off from https://codereview.chromium.org/2242743002/ . Could you review? https://codereview.chromium.org/2269493002/diff/1/third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html File third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html ...
4 years, 4 months ago (2016-08-22 02:18:53 UTC) #3
kochi
https://codereview.chromium.org/2269493002/diff/1/third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html File third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html (right): https://codereview.chromium.org/2269493002/diff/1/third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html#newcode15 third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html:15: // upgraded upon definition is ready. On 2016/08/22 02:18:53, ...
4 years, 4 months ago (2016-08-22 05:33:12 UTC) #8
dominicc (has gone to gerrit)
lgtm LGTM modulo spelling in the description: cutsom -> custom
4 years, 4 months ago (2016-08-22 08:09:10 UTC) #10
kochi
On 2016/08/22 08:09:10, dominicc wrote: > lgtm > > LGTM modulo spelling in the description: ...
4 years, 4 months ago (2016-08-22 08:15:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269493002/20001
4 years, 4 months ago (2016-08-22 08:16:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 08:19:56 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 08:21:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29016e7c9d34b097f40a53c8e5e709ef1aced2cb
Cr-Commit-Position: refs/heads/master@{#413419}

Powered by Google App Engine
This is Rietveld 408576698