third_party/WebKit/LayoutTests/fast/events/synthetic-events/tap-on-scaled-screen.html - Issue 2269483002: Set the coordinates of the synthetic touch event correctly in SyntheticGestureTargetAura

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/synthetic-events/tap-on-scaled-screen.html

Issue 2269483002: Set the coordinates of the synthetic touch event correctly in SyntheticGestureTargetAura (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/virtual/scalefactor200/fast/events/synthetic-events/README.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
	bokan 2016/08/24 15:56:57 please use <!DOCTYPE html> please use <!DOCTYPE html> lanwei 2016/08/25 02:28:56 Done. Show quoted text On 2016/08/24 15:56:57, bokan wrote: > please use <!DOCTYPE html> Done.
	2 <script src='../../../resources/testharness.js'></script>

	3 <script src='../../../resources/testharnessreport.js'></script>

	4 <style type="text/css">

	5 #box {

	6 width: 300px;

	7 height: 100px;

	8 }

	9 </style>

	10 <div id="box" ></div>

	11

	12 <script type="text/javascript">

	13

	14 test(function(t) {

	15 var receivedTap = false;

	16 var box = document.getElementById('box');

	17 var targetRect = box.getBoundingClientRect();

	18 var offset = 50;

	19 var x = targetRect.left + offset;

	20 var y = targetRect.top + offset;

	21

	22 function validTapResult(event) {

	23 receivedTap = true;

	24 assert_equals(event.target.id, "box");

	25 assert_equals(event.clientX, x);

	26 assert_equals(event.clientY, y);

	27 assert_equals(event.screenX, x);
	bokan 2016/08/24 15:56:57 This will only work if the window is at the top le This will only work if the window is at the top left corner of the screen. It'd be better to compare to \|x+window.screenX\| and \|y+window.screenY\| to make it more general. lanwei 2016/08/25 02:28:56 Acknowledged. Show quoted text On 2016/08/24 15:56:57, bokan wrote: > This will only work if the window is at the top left corner of the screen. It'd > be better to compare to \|x+window.screenX\| and \|y+window.screenY\| to make it > more general. Acknowledged.
	28 assert_equals(event.screenY, y);

	29 }

	30

	31 //function tap() {
	tdresser 2016/08/24 12:27:49 Remove commented out line (and below). Remove commented out line (and below). lanwei 2016/08/25 02:28:56 Done. Show quoted text On 2016/08/24 12:27:49, tdresser wrote: > Remove commented out line (and below). Done.
	32 var testTap = async_test('Send a tap event.');

	33 testTap.step(function () {

	34 box.addEventListener('click', validTapResult);

	35 if (window.chrome && chrome.gpuBenchmarking) {

	36 chrome.gpuBenchmarking.tap(x, y, function() {

	37 assert_true(receivedTap);

	38 testTap.done();});
	tdresser 2016/08/24 12:27:49 I think we'd normally put }); on the line below. I think we'd normally put }); on the line below. lanwei 2016/08/25 02:28:56 Done. Show quoted text On 2016/08/24 12:27:49, tdresser wrote: > I think we'd normally put }); on the line below. Done.
	39 }

	40 });

	41 //}

	42

	43 }, 'Test that chrome.gpuBenchmarking.tap always taps on the expected position no matter what the screen scale factor is.');

	44

	45 </script>

OLD	NEW