Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4878)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_eula.js

Issue 2269433002: ChromeOS: Add more controls to OOBE EULA screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_screen_eula.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_eula.js b/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
index 98da53b7ff2253ecda000ff7d920b21b2796cca7..8e0bca6b97fa4cef98106ed207f6e54fdb6339cd 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
@@ -39,11 +39,19 @@ login.createScreen('EulaScreen', 'eula', function() {
var self = this;
$('usage-stats').addEventListener('click', function(event) {
- self.context.set(CONTEXT_KEY_USAGE_STATS_ENABLED,
- $('usage-stats').checked);
- self.commitContextChanges();
+ self.onUsageStatsClicked_($('usage-stats').checked);
event.stopPropagation();
});
stevenjb 2016/08/23 16:45:17 The data-binding way to do this would be in the ht
Alexander Alekseev 2016/08/25 01:28:22 This doesn't work, because usage-stats is not a po
stevenjb 2016/08/25 16:43:46 I see. I get confused by the mix of polymer/non-po
+ $('oobe-eula-md').screen = this;
+ },
+
+ /*
stevenjb 2016/08/23 16:45:17 /**
Alexander Alekseev 2016/08/25 01:28:22 Done.
+ * Event handler for $('usage-stats') click event.
+ * @param {boolean} value $('usage-stats').checked value.
stevenjb 2016/08/23 16:45:17 align
Alexander Alekseev 2016/08/25 01:28:22 Done.
+ */
+ onUsageStatsClicked_: function(value) {
+ this.context.set(CONTEXT_KEY_USAGE_STATS_ENABLED, value);
+ this.commitContextChanges();
},
/**

Powered by Google App Engine
This is Rietveld 408576698