ChromeOS: Add more controls to OOBE EULA screen.

chrome/browser/resources/chromeos/login/oobe_screen_eula.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe eula screen implementation.
  */
 
 login.createScreen('EulaScreen', 'eula', function() {
   var CONTEXT_KEY_USAGE_STATS_ENABLED = 'usageStatsEnabled';
@@ skipping 21 matching lines @@
         // WebKit does not allow immediate focus return.
         window.setTimeout(function() {
           // TODO(ivankr): focus cycling.
           $('installation-settings-ok-button').focus();
         }, 0);
         event.preventDefault();
       });
 
       var self = this;
       $('usage-stats').addEventListener('click', function(event) {
-        self.context.set(CONTEXT_KEY_USAGE_STATS_ENABLED,
-                         $('usage-stats').checked);
-        self.commitContextChanges();
+        self.onUsageStatsClicked_($('usage-stats').checked);
         event.stopPropagation();
       });

[stevenjb, 2016/08/23 16:45:17]

The data-binding way to do this would be in the html:

on-tap="onUsageStatsClicked_"

Then in onUsageStatsClicked_:

var checked = event.currentTarget.checked;

And the addEventListener code wouldn't be needed at all.

[Alexander Alekseev, 2016/08/25 01:28:22]

This doesn't work, because usage-stats is not a polymer-enabled object.

And onClick="$('eula').onUsageStatsClicked_" violates security policy:

Refused to execute inline event handler because it violates the following
Content Security Policy directive: "script-src chrome://resources 'self'
'unsafe-eval'". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a
nonce ('nonce-...') is required to enable inline execution.

[stevenjb, 2016/08/25 16:43:46]

I see. I get confused by the mix of polymer/non-polymer here. This is fine.

+      $('oobe-eula-md').screen = this;
+    },
+
+    /*

[stevenjb, 2016/08/23 16:45:17]

/**

[Alexander Alekseev, 2016/08/25 01:28:22]

Done.

+     * Event handler for $('usage-stats') click event.
+     *  @param {boolean} value  $('usage-stats').checked value.

[stevenjb, 2016/08/23 16:45:17]

align

[Alexander Alekseev, 2016/08/25 01:28:22]

Done.

+     */
+    onUsageStatsClicked_: function(value) {
+      this.context.set(CONTEXT_KEY_USAGE_STATS_ENABLED, value);
+      this.commitContextChanges();
     },
 
     /**
      * Event handler that is invoked when 'chrome://terms' is loaded.
      */
     onFrameLoad: function() {
       $('accept-button').disabled = false;
       $('eula').classList.remove('eula-loading');
       // Initially, the back button is focused and the accept button is
       // disabled.
@@ skipping 79 matching lines @@
       if ($('cros-eula-frame').src) {
         $('cros-eula-frame').src = $('cros-eula-frame').src;
       }
       if ($('oem-eula-frame').src) {
         $('oem-eula-frame').src = $('oem-eula-frame').src;
       }
     }
   };
 });