Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2269423002: MD History: Tweak appearance of sign-in promotion (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Tweak appearance of sign-in promotion This changes the style of the sign-in button to better match the mocks, and changes font-sizes across the page to percentage-based, so they can resize according to user preferences. BUG=640422 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c Cr-Commit-Position: refs/heads/master@{#413983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
4 years, 4 months ago (2016-08-24 02:44:38 UTC) #5
calamity
lgtm
4 years, 4 months ago (2016-08-24 03:47:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269423002/1
4 years, 4 months ago (2016-08-24 05:05:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 05:09:10 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 05:10:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d1e08e2b3ed64b7fd44f0a902977aa0e62678c
Cr-Commit-Position: refs/heads/master@{#413983}

Powered by Google App Engine
This is Rietveld 408576698