Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h

Issue 22694006: Infobar system refactor. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h
===================================================================
--- chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h (revision 238220)
+++ chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h (working copy)
@@ -16,30 +16,24 @@
class ExtensionViewGtk;
class MenuGtk;
-class ExtensionInfoBarGtk : public InfoBarGtk,
- public MenuGtk::Delegate,
- public ExtensionInfoBarDelegate::DelegateObserver {
+class ExtensionInfoBarGtk : public InfoBarGtk, public MenuGtk::Delegate {
public:
- ExtensionInfoBarGtk(InfoBarService* owner,
- ExtensionInfoBarDelegate* delegate);
+ explicit ExtensionInfoBarGtk(scoped_ptr<ExtensionInfoBarDelegate> delegate);
private:
virtual ~ExtensionInfoBarGtk();
// InfoBarGtk:
+ virtual void PlatformSpecificSetOwner() OVERRIDE;
virtual void PlatformSpecificHide(bool animate) OVERRIDE;
virtual void GetTopColor(InfoBarDelegate::Type type,
double* r, double* g, double* b) OVERRIDE;
virtual void GetBottomColor(InfoBarDelegate::Type type,
double* r, double* g, double* b) OVERRIDE;
- virtual void InitWidgets() OVERRIDE;
// MenuGtk::Delegate:
virtual void StoppedShowing() OVERRIDE;
- // ExtensionInfoBarDelegate::DelegateObserver:
- virtual void OnDelegateDeleted() OVERRIDE;
-
void OnImageLoaded(const gfx::Image& image);
ExtensionInfoBarDelegate* GetDelegate();
@@ -61,11 +55,6 @@
CHROMEGTK_CALLBACK_1(ExtensionInfoBarGtk, gboolean, OnExpose,
GdkEventExpose*);
- // TODO(pkasting): This shadows InfoBarView::delegate_. Get rid of this once
- // InfoBars own their delegates (and thus we don't need the DelegateObserver
- // functionality). For now, almost everyone should use GetDelegate() instead.
- InfoBarDelegate* delegate_;
-
ExtensionViewGtk* view_;
// The button that activates the extension popup menu. Non-NULL if the
« no previous file with comments | « chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc ('k') | chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698