InstantExtended: Nuke InstantOverlayController.

InstantExtended: Nuke InstantOverlayController.

There is no longer an Instant overlay that needs controlling, so we can
remove InstantOverlayController. Mac's view code is warped around the
existence of an overlay, so cut out as much of the dead Instant code as
possible without removing OverlayableContentsController; I'm not a Cocoa
expert and don't know the best way to do that.

BUG=251262
TEST=None.
TBR=erg@chromium.org, rsesek@chromium.org, samarth@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217079

[Jered, 2013-08-09 09:37:11]

Please review.
avi -> cocoa
brettw -> chrome, history
erg ->gtk

[Jered, 2013-08-09 09:39:52]

Also samarth -> instant

[Elliot Glaysher, 2013-08-09 17:21:36]

I love the smell of deleted code in the morning.

gtk parts lgtm

[Avi (use Gerrit), 2013-08-09 22:20:38]

Tossing to Robert to handle while I'm away.

[Robert Sesek, 2013-08-12 15:08:37]

cocoa/ LGTM with more deletions

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
File chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm
(right):

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm:10:
@interface OverlayableContentsController()
Delete this and the line below, too.

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm:30: -
(void)dealloc {
Can remove this entire method, too.

[Jered, 2013-08-12 18:11:08]

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
File chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm
(right):

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm:10:
@interface OverlayableContentsController()
On 2013/08/12 15:08:37, rsesek wrote:
> Delete this and the line below, too.

Done.

https://codereview.chromium.org/22694002/diff/21001/chrome/browser/ui/cocoa/t...
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm:30: -
(void)dealloc {
On 2013/08/12 15:08:37, rsesek wrote:
> Can remove this entire method, too.

Done.

[samarth, 2013-08-12 20:34:20]

lgtm yay

https://codereview.chromium.org/22694002/diff/32001/chrome/browser/ui/cocoa/t...
File chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h
(right):

https://codereview.chromium.org/22694002/diff/32001/chrome/browser/ui/cocoa/t...
chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h:24: //
TODO(sail): Remove this class and replace it with something saner.
FYI sail is back so you can get his view on this :)

[Jered, 2013-08-12 20:41:58]

+sail -> cocoa stuff
Sail is this an ok intermediate state or should I hand off this patch, since
it's mostly cocoa?

TBR brettw since the other changes are trivial.

[sail, 2013-08-12 21:17:35]

On 2013/08/12 20:41:58, Jered wrote:
> +sail -> cocoa stuff
> Sail is this an ok intermediate state or should I hand off this patch, since
> it's mostly cocoa?
> 
> TBR brettw since the other changes are trivial.

This CL looks great. I'll send out a separate CL to delete the remaining code.
Thanks.

[Jered, 2013-08-12 21:26:04]

On 2013/08/12 21:17:35, sail wrote:
> On 2013/08/12 20:41:58, Jered wrote:
> > +sail -> cocoa stuff
> > Sail is this an ok intermediate state or should I hand off this patch, since
> > it's mostly cocoa?
> > 
> > TBR brettw since the other changes are trivial.
> 
> This CL looks great. I'll send out a separate CL to delete the remaining code.
> Thanks.

Sure np. I'm reasonably sure the failures here are bogus so will dcommit.

[Jered, 2013-08-12 21:28:53]

Committed patchset #4 manually as r217079 (presubmit successful).