Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2269383004: Adds TODO with reference to bug (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds TODO with reference to bug Also changes NOTIMPLEMENTED policies a bit. BUG=640773 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/c475ac557c95561e3f1770c7034ca05903b6dafa Cr-Commit-Position: refs/heads/master@{#414261}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 2 chunks +2 lines, -4 lines 1 comment Download
M ui/views/mus/screen_mus.cc View 2 chunks +4 lines, -5 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
sky
https://codereview.chromium.org/2269383004/diff/1/ash/mus/bridge/wm_window_mus.cc File ash/mus/bridge/wm_window_mus.cc (left): https://codereview.chromium.org/2269383004/diff/1/ash/mus/bridge/wm_window_mus.cc#oldcode32 ash/mus/bridge/wm_window_mus.cc:32: // TODO(sky): fully implement this. Making DVLOG as too ...
4 years, 3 months ago (2016-08-24 22:51:32 UTC) #1
James Cook
LGTM https://codereview.chromium.org/2269383004/diff/1/ui/views/mus/screen_mus.cc File ui/views/mus/screen_mus.cc (right): https://codereview.chromium.org/2269383004/diff/1/ui/views/mus/screen_mus.cc#newcode7 ui/views/mus/screen_mus.cc:7: #define NOTIMPLEMENTED_POLICY 5 Could this live in the ...
4 years, 3 months ago (2016-08-24 23:15:37 UTC) #4
sky
https://codereview.chromium.org/2269383004/diff/1/ui/views/mus/screen_mus.cc File ui/views/mus/screen_mus.cc (right): https://codereview.chromium.org/2269383004/diff/1/ui/views/mus/screen_mus.cc#newcode7 ui/views/mus/screen_mus.cc:7: #define NOTIMPLEMENTED_POLICY 5 On 2016/08/24 23:15:37, James Cook wrote: ...
4 years, 3 months ago (2016-08-24 23:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269383004/1
4 years, 3 months ago (2016-08-24 23:26:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 02:20:53 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:23:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c475ac557c95561e3f1770c7034ca05903b6dafa
Cr-Commit-Position: refs/heads/master@{#414261}

Powered by Google App Engine
This is Rietveld 408576698