Certificate Transparency: Make DNS front-end required.

Certificate Transparency: Make DNS front-end required.

From an out-of-band discussion with rsleevi came the conclusion that
all CT logs, including ones that ceased operation, must be auditable
(since some of their SCTs are accepted).

This change ensures that if logs are added to the known logs list
without a DNS front-end address, it will be detected on start-up.

BUG=624894
Committed: https://crrev.com/efc343f3e590013c880525c0d934f1322dc5438d
Cr-Commit-Position: refs/heads/master@{#414389}

[Eran Messeri, 2016-08-24 14:23:45]

eranm@chromium.org changed reviewers:
+ robpercival@chromium.org, rsleevi@chromium.org

[Eran Messeri, 2016-08-24 14:24:02]

The CQ bit was checked by eranm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 14:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:37:38]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2016-08-25 04:17:46]

Remove the .md addition and LGTM

I think it's good to add documentation related to the code, but I'd love to see
us expand a bit on the documentation. I'm not terribly keen on "notes about CT"
because that's the sort of thing that can easily become like a _util.h file -
all sorts of unrelated notes go in, and it becomes hard to see the big picture.

I'd be happy to set up some time to videochat, or we could collaborate on a doc,
on the sort of things we'd want to actually put down in a .md doc (and the risks
with updating)

https://cs.chromium.org/chromium/src/net/docs/life-of-a-url-request.md I think
is a good example that provides the overview of how things work and thread
through, and some of the nuances, and I think at that layer, we could talk about
everything in //net (e.g. I'm not gonna haggle about "layering" :P)

[Eran Messeri, 2016-08-25 09:30:12]

Description was changed from

==========
Certificate Transparency: Make DNS front-end required.

From an out-of-band discussion with rsleevi came the conclusion that
all CT logs, including ones that ceased operation, must be auditable
(since some of their SCTs are accepted).

This change ensures that if logs are added to the known logs list
without a DNS front-end address, it will be detected on start-up.

The rationale is also laid out in the newly-added document to net/docs.

BUG=624894
==========

to

==========
Certificate Transparency: Make DNS front-end required.

From an out-of-band discussion with rsleevi came the conclusion that
all CT logs, including ones that ceased operation, must be auditable
(since some of their SCTs are accepted).

This change ensures that if logs are added to the known logs list
without a DNS front-end address, it will be detected on start-up.

BUG=624894
==========

[Eran Messeri, 2016-08-25 09:38:02]

On 2016/08/25 at 04:17:46, rsleevi wrote:
> Remove the .md addition and LGTM
> 
> I think it's good to add documentation related to the code, but I'd love to
see us expand a bit on the documentation. I'm not terribly keen on "notes about
CT" because that's the sort of thing that can easily become like a _util.h file
- all sorts of unrelated notes go in, and it becomes hard to see the big
picture.
> 
> I'd be happy to set up some time to videochat, or we could collaborate on a
doc, on the sort of things we'd want to actually put down in a .md doc (and the
risks with updating)
> 
> https://cs.chromium.org/chromium/src/net/docs/life-of-a-url-request.md I think
is a good example that provides the overview of how things work and thread
through, and some of the nuances, and I think at that layer, we could talk about
everything in //net (e.g. I'm not gonna haggle about "layering" :P)

Removed.
Let's follow up over VC about adding CT-related documentation. I agree that
there was high risk for this document to become a dumping ground for all sorts
of CT odds-and-ends and still not sure where the rationale for this change
should be documented.

[Eran Messeri, 2016-08-25 09:38:13]

The CQ bit was checked by eranm@chromium.org

[Eran Messeri, 2016-08-25 09:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2269383003/#ps20001
(title: "Removing the md file")

[commit-bot: I haz the power, 2016-08-25 09:38:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:04:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 11:06:43]

Description was changed from

==========
Certificate Transparency: Make DNS front-end required.

From an out-of-band discussion with rsleevi came the conclusion that
all CT logs, including ones that ceased operation, must be auditable
(since some of their SCTs are accepted).

This change ensures that if logs are added to the known logs list
without a DNS front-end address, it will be detected on start-up.

BUG=624894
==========

to

==========
Certificate Transparency: Make DNS front-end required.

From an out-of-band discussion with rsleevi came the conclusion that
all CT logs, including ones that ceased operation, must be auditable
(since some of their SCTs are accepted).

This change ensures that if logs are added to the known logs list
without a DNS front-end address, it will be detected on start-up.

BUG=624894

Committed: https://crrev.com/efc343f3e590013c880525c0d934f1322dc5438d
Cr-Commit-Position: refs/heads/master@{#414389}
==========

[commit-bot: I haz the power, 2016-08-25 11:06:44]

Patchset 2 (id:??) landed as
https://crrev.com/efc343f3e590013c880525c0d934f1322dc5438d
Cr-Commit-Position: refs/heads/master@{#414389}