Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: ash/magnifier/partial_magnification_controller.h

Issue 2269383002: Magnifier border is now more visible on light backgrounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed memory leak. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/magnifier/partial_magnification_controller.h
diff --git a/ash/magnifier/partial_magnification_controller.h b/ash/magnifier/partial_magnification_controller.h
index 3a7cf0fdcf926f886e6eace327832679857520a5..b6f5dc32ad788eba3744d82b974fcbb090802596 100644
--- a/ash/magnifier/partial_magnification_controller.h
+++ b/ash/magnifier/partial_magnification_controller.h
@@ -47,6 +47,7 @@ class ASH_EXPORT PartialMagnificationController : public ui::EventHandler,
private:
friend class PartialMagnificationControllerTestApi;
+ class BorderRenderer;
class ContentMask;
// ui::EventHandler:
@@ -84,6 +85,8 @@ class ASH_EXPORT PartialMagnificationController : public ui::EventHandler,
std::unique_ptr<ui::Layer> zoom_layer_;
// Draws an outline that is overlayed on top of |zoom_layer_|.
std::unique_ptr<ui::Layer> border_layer_;
+ // Draws a multicolored black/white/black border on top of |border_layer_|.
+ std::unique_ptr<BorderRenderer> border_renderer_;
James Cook 2016/09/16 01:48:52 optional: Consider documenting that this must be d
sammiequon 2016/09/16 16:33:35 Done.
// Masks the content of |zoom_layer_| so that only a circle is magnified.
std::unique_ptr<ContentMask> zoom_mask_;
// Masks the content of |border_layer_| so that only a circle outline is
« no previous file with comments | « no previous file | ash/magnifier/partial_magnification_controller.cc » ('j') | ash/magnifier/partial_magnification_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698