src/core/SkColorSpace_ICC.cpp - Issue 2269333002: Parse ICC profiles from webps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkColorSpace_ICC.cpp

Issue 2269333002: Parse ICC profiles from webps (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add resources Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkColorSpace_ICC.cpp

diff --git a/src/core/SkColorSpace_ICC.cpp b/src/core/SkColorSpace_ICC.cpp

index 9ab1da007d16e8dee5aa5dae7b0a358d65effcb9..c00f5d9d6d4465ec410cda5cd49161907f25dc83 100755

--- a/src/core/SkColorSpace_ICC.cpp

+++ b/src/core/SkColorSpace_ICC.cpp

@@ -138,7 +138,7 @@ struct ICCProfileHeader {

// Should we treat different rendering intents differently?

// Valid rendering intents include kPerceptual (0), kRelative (1),

// kSaturation (2), and kAbsolute (3).

- if (fRenderingIntent <= 3) {

+ if (fRenderingIntent > 3) {

mtklein 2016/08/24 12:56:50 Think we should land this separately, in case of r

msarett 2016/08/24 13:14:24 Done.

// Warn rather than fail here. Occasionally, we see perfectly

// normal profiles with wacky rendering intents.

SkColorSpacePrintf("Warning, bad rendering intent.\n");