Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2269323002: [wasm] Remember import indices with the compiled module (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remember import indices When compiling a wasm module, we initially generate placeholders for imports, which store the index corresponding to that import. Later, at instantiation time, we use that index to correctly link the provided import. In this scheme, supporting multiple instantiations requires we preserve a template (set of unlinked compiled wasm functions) which we clone for each instance. To avoid holding on to this template, which may be large (wasm compiled code should be expected to be in the order of tens of MB), we must enable cloning from an instance's linked wasm functions. This change is a step in that direction. Instead of assuming the wasm functions reference placeholders, we store a table of the code objects used for imports together with the compiled module, and use that information to determine the index of the import. Initially, that table contains placeholders. For instances, however, that table contains their actual imports. BUG= Committed: https://crrev.com/5524cbf5b8324051da7145ef3c8b7e80b2e7ab28 Cr-Commit-Position: refs/heads/master@{#38848}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -21 lines) Patch
M src/wasm/wasm-module.cc View 1 5 chunks +57 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Mircea Trofin
ptal
4 years, 4 months ago (2016-08-23 23:34:54 UTC) #8
bradnelson
lgtm
4 years, 4 months ago (2016-08-24 00:23:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269323002/20001
4 years, 4 months ago (2016-08-24 00:23:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 00:26:01 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 00:26:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5524cbf5b8324051da7145ef3c8b7e80b2e7ab28
Cr-Commit-Position: refs/heads/master@{#38848}

Powered by Google App Engine
This is Rietveld 408576698