Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2269303002: Set up Blimp Integration script on FYI bot (Closed)

Created:
4 years, 4 months ago by shenghuazhang
Modified:
4 years ago
Reviewers:
jbudorick
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Set up Blimp Integration script on FYI bot Script: blimp/tools/client_engine_integration.py Bot: chromium.fyi Starts by 'client_engine_integration.py start'. Installs/loads after checking json file existing. Cleans up env in finally block. Linked CL (Detach engine process): https://codereview.chromium.org/2283083002/ BUG=640368

Patch Set 1 #

Patch Set 2 : Set up Blimp Integration script on FYI bot #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -68 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 2 chunks +49 lines, -1 line 3 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Blimp_Integration_Test.json View 1 11 chunks +90 lines, -66 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
shenghuazhang
4 years, 3 months ago (2016-08-26 19:37:13 UTC) #4
jbudorick
https://codereview.chromium.org/2269303002/diff/20001/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/2269303002/diff/20001/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode1765 scripts/slave/recipe_modules/chromium_tests/steps.py:1765: api.chromium.set_config('chromium', TARGET_PLATFORM='linux') I don't think a Test step is ...
4 years, 3 months ago (2016-08-26 21:22:38 UTC) #5
jbudorick
4 years, 3 months ago (2016-09-13 02:44:33 UTC) #6
Sorry about the delay here.

After thinking about this more (and as we've discussed offline, albeit briefly),
I think that a dedicated recipe is better suited to the double build that this
has to do. We can probably use *some* of the same calls that
api.chromium_tests.main_waterfall_steps does -- create_bot_config_object,
configure_build, prepare_checkout, and get_tests should all be usable.
get-compile_targets and compile_specific_targets might be usable, though we'd
have to run them twice (unsurprisingly) and in different directories. It may be
simpler to call some of the things those functions call directly; I'm not sure.

Powered by Google App Engine
This is Rietveld 408576698