Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2269283002: Change "tryjob" -> "try job" in git_cl.py and trychange.py. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change "tryjob" -> "try job" in git_cl.py and trychange.py. I know this is an unimportant change, and that across Chromium, "try job" and "tryjob", and "try bot" and "trybot" are basically interchangeable, still I think it's nice to have the spelling consistent within one module. I prefer the version with a space just because that's what's used in the documentation: https://www.chromium.org/developers/testing/try-server-usage Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/eab3c0431157226b2638af23545d3f17bd04a25d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M git_cl.py View 8 chunks +11 lines, -11 lines 0 comments Download
M trychange.py View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
qyearsley
4 years, 4 months ago (2016-08-23 22:13:24 UTC) #2
tandrii(chromium)
LGTM i have no preference.
4 years, 4 months ago (2016-08-24 11:33:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269283002/1
4 years, 4 months ago (2016-08-24 16:15:14 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:18:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/eab3c043115722...

Powered by Google App Engine
This is Rietveld 408576698