Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2269253002: In rebaseline-cl, trigger try jobs with builder per invocation of git cl try. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In rebaseline-cl, trigger try jobs with builder per invocation of git cl try. If android_blink_rel is included in the list of try bots, then using git cl try with all of the try bots including that one will fail. Some alternative possible solutions: - Make an explicit special case for android_blink_rel, starting that one in a separate command. - Remove android_blink_rel from the list of builders again. - Remove android_blink_rel only from the list of builders triggered here. Committed: https://crrev.com/44ce301713688bb031e2b3b45bae7071aae71d57 Cr-Commit-Position: refs/heads/master@{#414152}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased and removed printing of git cl try output. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
qyearsley
4 years, 4 months ago (2016-08-23 21:01:28 UTC) #2
wkorman
https://codereview.chromium.org/2269253002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py (right): https://codereview.chromium.org/2269253002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py#newcode106 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:106: _log.info(git_cl.run(['try', '-b', builder])) remove log wrapper, looks like debugging?
4 years, 4 months ago (2016-08-23 23:30:46 UTC) #3
qyearsley
https://codereview.chromium.org/2269253002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py (right): https://codereview.chromium.org/2269253002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py#newcode106 third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:106: _log.info(git_cl.run(['try', '-b', builder])) On 2016/08/23 at 23:30:46, wkorman wrote: ...
4 years, 4 months ago (2016-08-24 18:17:44 UTC) #4
Dirk Pranke
lgtm. It would be good to fix this in git-cl try.
4 years, 4 months ago (2016-08-24 18:22:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269253002/40001
4 years, 4 months ago (2016-08-24 20:07:27 UTC) #12
qyearsley
On 2016/08/24 at 18:22:23, dpranke wrote: > lgtm. > > It would be good to ...
4 years, 4 months ago (2016-08-24 20:54:52 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 21:34:29 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 21:36:24 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44ce301713688bb031e2b3b45bae7071aae71d57
Cr-Commit-Position: refs/heads/master@{#414152}

Powered by Google App Engine
This is Rietveld 408576698