Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 226923003: Fixes for sandbox unit tests on Android (Closed)

Created:
6 years, 8 months ago by Zhenyu Liang
Modified:
6 years, 8 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, Robert Sesek
Visibility:
Public.

Description

Fixes for sandbox unit tests on Android In bionic, open, access and dup2 are wrappers of openat, faccessat and dup3 instead of real syscalls. BUG=166704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 5 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Zhenyu Liang
6 years, 8 months ago (2014-04-10 11:07:56 UTC) #1
jln (very slow on Chromium)
lgtm, thanks a lot for the fixes!
6 years, 8 months ago (2014-04-10 18:47:03 UTC) #2
Jorge Lucangeli Obes
lgtm
6 years, 8 months ago (2014-04-10 18:52:23 UTC) #3
Zhenyu Liang
The CQ bit was checked by zhenyu.liang@intel.com
6 years, 8 months ago (2014-04-10 19:27:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/226923003/1
6 years, 8 months ago (2014-04-10 19:28:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 20:48:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-10 20:48:54 UTC) #7
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 8 months ago (2014-04-10 21:01:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhenyu.liang@intel.com/226923003/1
6 years, 8 months ago (2014-04-10 21:02:39 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 22:46:14 UTC) #10
Message was sent while issue was closed.
Change committed as 263107

Powered by Google App Engine
This is Rietveld 408576698