Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2269203002: Deleting unused methods from CFX_RenderDevice (Closed)

Created:
4 years, 4 months ago by npm
Modified:
4 years, 4 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Delete unused methods from CFX_RenderDevice Committed: https://pdfium.googlesource.com/pdfium/+/63af2c64b4ea9a0de9a9b4e9916b7f2c925e4b38

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -63 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M core/fxge/ge/cfx_renderdevice.cpp View 1 5 chunks +23 lines, -33 lines 0 comments Download
M core/fxge/include/cfx_renderdevice.h View 1 3 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
npm
PTAL
4 years, 4 months ago (2016-08-23 20:02:27 UTC) #7
dsinclair
lg. caryclark@ will Skia need these in the future?
4 years, 4 months ago (2016-08-23 20:08:22 UTC) #9
Lei Zhang
+other cary https://codereview.chromium.org/2269203002/diff/1/core/fxge/include/cfx_renderdevice.h File core/fxge/include/cfx_renderdevice.h (right): https://codereview.chromium.org/2269203002/diff/1/core/fxge/include/cfx_renderdevice.h#newcode139 core/fxge/include/cfx_renderdevice.h:139: FX_BOOL DrawCosmeticLineWithFillModeAndBlend(FX_FLOAT x1, Just rename this back ...
4 years, 4 months ago (2016-08-23 20:11:29 UTC) #11
caryclark
lgtm (as far as Skia needing these in the future)
4 years, 4 months ago (2016-08-23 20:27:12 UTC) #12
npm
Renamed https://codereview.chromium.org/2269203002/diff/1/core/fxge/include/cfx_renderdevice.h File core/fxge/include/cfx_renderdevice.h (right): https://codereview.chromium.org/2269203002/diff/1/core/fxge/include/cfx_renderdevice.h#newcode139 core/fxge/include/cfx_renderdevice.h:139: FX_BOOL DrawCosmeticLineWithFillModeAndBlend(FX_FLOAT x1, On 2016/08/23 20:11:29, Lei Zhang ...
4 years, 4 months ago (2016-08-23 20:40:40 UTC) #15
dsinclair
lgtm
4 years, 4 months ago (2016-08-24 13:33:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269203002/20001
4 years, 4 months ago (2016-08-24 13:33:42 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:34:00 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/63af2c64b4ea9a0de9a9b4e9916b7f2c925e...

Powered by Google App Engine
This is Rietveld 408576698