Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: components/offline_pages/background/request_picker_unittest.cc

Issue 2269173003: Adjust scheduling for non-user requested items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tests written and working. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_picker_unittest.cc
diff --git a/components/offline_pages/background/request_picker_unittest.cc b/components/offline_pages/background/request_picker_unittest.cc
index b6c1dc82604519da60b5c972264f0499dd2be5d7..ac5b9d9c002f66fd04282a3d8db6bf94e861a117 100644
--- a/components/offline_pages/background/request_picker_unittest.cc
+++ b/components/offline_pages/background/request_picker_unittest.cc
@@ -93,7 +93,7 @@ class RequestPickerTest : public testing::Test {
void RequestPicked(const SavePageRequest& request);
- void RequestQueueEmpty();
+ void RequestQueueEmpty(const bool non_user_requested_tasks_remaining);
void QueueRequestsAndChooseOne(const SavePageRequest& request1,
const SavePageRequest& request2);
@@ -143,7 +143,8 @@ void RequestPickerTest::RequestPicked(const SavePageRequest& request) {
last_picked_.reset(new SavePageRequest(request));
}
-void RequestPickerTest::RequestQueueEmpty() {
+void RequestPickerTest::RequestQueueEmpty(
dougarnett 2016/08/29 15:47:22 rename here too
Pete Williamson 2016/09/01 00:10:31 Done.
+ const bool non_user_requested_tasks_remaining) {
request_queue_empty_called_ = true;
}

Powered by Google App Engine
This is Rietveld 408576698