Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: components/offline_pages/background/request_picker.cc

Issue 2269173003: Adjust scheduling for non-user requested items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_picker.cc
diff --git a/components/offline_pages/background/request_picker.cc b/components/offline_pages/background/request_picker.cc
index c8e597b772db75e2e751828db01150743ccaf450..c8a4aafa58674190f42a38b598d04c7b30a4120b 100644
--- a/components/offline_pages/background/request_picker.cc
+++ b/components/offline_pages/background/request_picker.cc
@@ -53,7 +53,7 @@ void RequestPicker::GetRequestResultCallback(
const std::vector<SavePageRequest>& requests) {
// If there is nothing to do, return right away.
if (requests.size() == 0) {
- empty_callback_.Run();
+ empty_callback_.Run(false);
return;
}
@@ -82,7 +82,10 @@ void RequestPicker::GetRequestResultCallback(
comparator = &RequestPicker::RecencyFirstCompareFunction;
// Iterate once through the requests, keeping track of best candidate.
+ bool non_user_requested_tasks_remaining = false;
for (unsigned i = 0; i < valid_requests.size(); ++i) {
+ if (!valid_requests[i].user_requested())
+ non_user_requested_tasks_remaining = true;
if (!RequestConditionsSatisfied(valid_requests[i]))
continue;
if (IsNewRequestBetter(picked_request, &(valid_requests[i]), comparator))
@@ -94,7 +97,7 @@ void RequestPicker::GetRequestResultCallback(
if (picked_request != nullptr) {
picked_callback_.Run(*picked_request);
} else {
- empty_callback_.Run();
+ empty_callback_.Run(non_user_requested_tasks_remaining);
}
}

Powered by Google App Engine
This is Rietveld 408576698