Adjust scheduling for non-user requested items

components/offline_pages/background/request_picker.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_PICKER_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_PICKER_H_
 
 #include <memory>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 14 matching lines @@
   RequestPicker(RequestQueue* requestQueue,
                 OfflinerPolicy* policy,
                 RequestNotifier* notifier);
 
   ~RequestPicker();
 
   // Choose which request we should process next based on the current
   // conditions, and call back to the RequestCoordinator when we have one.
   void ChooseNextRequest(
       RequestCoordinator::RequestPickedCallback picked_callback,
-      RequestCoordinator::RequestQueueEmptyCallback empty_callback,
+      RequestCoordinator::RequestNotPickedCallback empty_callback,

[dougarnett, 2016/09/01 18:24:13]

not_picked_callback ?

[Pete Williamson, 2016/09/01 21:56:08]

Done.

       DeviceConditions* device_conditions);
 
  private:
   // Callback for the GetRequest results to be delivered.
   void GetRequestResultCallback(RequestQueue::GetRequestsResult result,
                                 const std::vector<SavePageRequest>& results);
 
   // Filter out requests that don't meet the current conditions.  For instance,
   // if this is a predictive request, and we are not on WiFi, it should be
   // ignored this round.
@@ skipping 39 matching lines @@
   RequestNotifier* notifier_;
   // Current conditions on the device
   std::unique_ptr<DeviceConditions> current_conditions_;
   // True if we prefer less-tried requests
   bool fewer_retries_better_;
   // True if we prefer requests submitted more recently
   bool earlier_requests_better_;
   // Callback for when we are done picking a request to do next.
   RequestCoordinator::RequestPickedCallback picked_callback_;
   // Callback for when there are no more reqeusts to pick.
-  RequestCoordinator::RequestQueueEmptyCallback empty_callback_;
+  RequestCoordinator::RequestNotPickedCallback not_picked_callback_;
   // Allows us to pass a weak pointer to callbacks.
   base::WeakPtrFactory<RequestPicker> weak_ptr_factory_;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_PICKER_H_